Changed calculateSpace to fix order of discrete and continuous variables #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-or
approved these changes
Jul 23, 2021
utility/converters.ts
Outdated
|
|
||
| const numerical: SpaceType = experiment.valueVariables.map(v => { if(v.discrete) { | ||
| return {type: "discrete", name: v.name, from: Number(v.minVal), to: Number(v.maxVal)}} | ||
| else {return {type: "continuous", name: v.name, from: Number(v.minVal), to: Number(v.maxVal)}} }) |
There was a problem hiding this comment.
Could be simplified a little by only having one return since both objects are very similar...
const type = v.discrete ? "discrete" : "continuous"
return {type, name: v.name, from: Number(v.minVal), to: Number(v.maxVal)}
...if you prefer. But yours works fine too.
There was a problem hiding this comment.
That is definitely more elegant. Thanks for the suggestion, it is very helpful for me :) I will make an update before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed calculateSpace to fix order of discrete and continuous variables. With this solution they are returned in the same order as they were inputted and correspond to the headers in the frontend